Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-wordpress): only diff wpgraphql schema if the user opts in #38856

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

TylerBarnes
Copy link
Contributor

Schema diffing was added by default to help catch issues with how the local WP schema is generated. In 99% of cases this is not helpful, so it was a mistake to make this the default behaviour.
This is only useful as a diagnostic tool when investigating a bug

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 17, 2024
@pieh pieh added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 20, 2024
pieh
pieh previously approved these changes Feb 20, 2024
@pieh pieh merged commit 5bd4c25 into master Feb 20, 2024
33 of 34 checks passed
@pieh pieh deleted the fix/local-generated-typenames branch February 20, 2024 15:10
pieh pushed a commit that referenced this pull request Feb 20, 2024
…opts in (#38856)

* only diff wpgraphql schema if the user opts in

* Update config.yml

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 5bd4c25)
pieh pushed a commit that referenced this pull request Feb 21, 2024
…opts in (#38856) (#38860)

* only diff wpgraphql schema if the user opts in

* Update config.yml

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 5bd4c25)

Co-authored-by: Tyler Barnes <[email protected]>
This was referenced May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

2 participants