Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-adapter-netlify): adapter use headerRoutes (#38652) #38674

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

gatsbybot
Copy link
Collaborator

Backporting #38652 to the 5.12 release branch

(cherry picked from commit 22c2412)

* simplified header rules

* lint

* lint

* update test/snapshot

* update snapshot

* add snapshot for headerRoutes

* adapter use headerRoutes

* export type

* first pass at headers tests

* merge conflict fix

* lint error

* remove accidental nesting

* tests

* tests

* static assets todo

* example of permanent caching header assertion

* ensure getServerData header has priority over config header for SSR pages

* normalize header values before assertions

* add page- and app-data header checks

* tmp: skip deleting deploys for easier iteration

* refactor test a bit so it's easier to assert same thing in multiple tests + add assertions for js assets

* add slice-data headers check

* add static query result header test

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 22c2412)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 31, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 31, 2023
@pieh pieh merged commit 8ae5702 into release/5.12 Oct 31, 2023
33 checks passed
@pieh pieh deleted the backport-5.12-38652 branch October 31, 2023 12:15
This was referenced Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants