test(adapters-e2e): deploy to platform instead of ntl serve #38643
Conversation
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: adapters
| cy.intercept("/static/astro-**.png").as("img-import") | ||
| cy.intercept("/static/astro-**.png", req => { | ||
| req.on("before:response", res => { | ||
| // this generally should be permamently cached, but that cause problems with intercepting | ||
| // see https://docs.cypress.io/api/commands/intercept#cyintercept-and-request-caching | ||
| // so we disable caching for this response | ||
| // tests for cache-control headers should be done elsewhere | ||
|
|
||
| cy.visit('/').waitForRouteChange() | ||
| res.headers["cache-control"] = "no-store" | ||
| }) | ||
| }).as("img-import") | ||
|
|
||
| cy.visit("/").waitForRouteChange() |
There was a problem hiding this comment.
This is only real change in test - rest of it is just autoformatting (yikes). Apperently with ntl serve permanent caching wasn't really happing and test setup is kind of meh when that happens ( https://docs.cypress.io/api/commands/intercept#cyintercept-and-request-caching ), so this is just workaround to get test working (and probably note to actually add proper caching behavior tests in the future PR)
There was a problem hiding this comment.
Overall LGTM, don’t really have any blockers but a couple of questions only:
- Any particular reason not to integrate with Netlify’s CI/CD system instead and let these build on push as deploy previews, etc. instead of going through the CLI triggers?
- Seems like the deletion of deploys is configurable but wondering if we might want to always keep those around for debug purposes?
This was easier to setup for build to use changes in Pull Requests (because it was already using it). To use Netlify's CI/CD I would need to come up with a method to build packages here and link them together (I think that would be doable, would just require extra effort)
For |
* test(adapters-e2e): deploy to platform instead of ntl serve * test: clear browser cache for interception tests * test: delete deploy after the test * test: how about not caching things to begin with? * chore: update comment, only disable caching for webpack asset, restore previous assertions (cherry picked from commit 5bc0992)
…38662) * test(adapters-e2e): deploy to platform instead of ntl serve * test: clear browser cache for interception tests * test: delete deploy after the test * test: how about not caching things to begin with? * chore: update comment, only disable caching for webpack asset, restore previous assertions (cherry picked from commit 5bc0992) Co-authored-by: Michal Piechowiak <[email protected]>
Description
This moves adapters e2e tests setup to actually deploy and test against platform and not against
ntl serve.Documentation
Tests
One test was adjusted a bit to pass (setup isn't great overall for this test, so while not ideal - this should do for now to get e2e tests to use platform and be able to start adding more tests along the adapter related fixes for more confidence overall)
Related Issues
FRA-44