fix(gatsby): open lmdb instances in writeable locations in generated ssr/dsg function #38631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
commented
Oct 12, 2023
Comment on lines
+157
to
-152
| console.log(`Downloaded datastore from CDN`) | ||
| } | ||
| console.log(`Downloaded datastore from CDN`) |
There was a problem hiding this comment.
This is unrelated to rest of changes, just noticed this was logged even if LMDB wasn't excluded from the bundle (so when it shouldn't be logged)
pieh
added
topic: render-mode
|
@pieh Can we do a release for this fix? Having this issue in production version of code hosted on netlify |
pieh
added a commit
that referenced
this pull request
Oct 17, 2023
…ssr/dsg function (#38631) (#38638) (cherry picked from commit 3af35ae) Co-authored-by: Michal Piechowiak <[email protected]>
|
cc @madhums |
This was referenced Nov 7, 2023
This was referenced Dec 22, 2023
This was referenced Dec 29, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
caches-lmdbANDgatsby-core-utilsgetStorageopen lmdb cache/storage instances in writeable location (in case CWD in lambda environment is not writeable). The FS rewrites we have there now doesn't apply to LMDB (fs handling of lmdb is not in Node.js land) so we have to explicitly deal with "fs rewrite" when LMDB is concerned. We were already addressing this for main LMDB instance (datastore), but this expands it tocacheandstorageusage of lmdb as well.gatsby-core-utilsis already usingglobal.__GATSBY.root-gatsby/packages/gatsby-core-utils/src/utils/get-storage.ts
Lines 29 to 32 in 47ec2ac
This PR adds similar usage to lmdb cache usage, as well as actually sets the root to writeable location in lambda
Documentation
Tests
This is example showing segfault problem caused by trying to open LMDB in non-writeable location - https://6527cb3ca4fc76285774d547--exquisite-pavlova-cc785c.netlify.app/
https://6527d2acfad30e0085a57db2--exquisite-pavlova-cc785c.netlify.app/ this one is using changes from this PR showing it fixing the problem.
Related Issues
Fixes FRA-10
https://github.com/netlify/pillar-support/issues/724