chore(deps): upgrade sharp to latest v0.32.6 #38374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: media
Ensures some PNG-related test snapshots use deterministic raw pixel data rather than non-deterministic compressed byte streams.
lovell
force-pushed
the
chore-deps-upgrade-sharp-0.32.4
branch
from
e5e34a4
to
8d93e33
Compare
lovell
changed the title
pieh
changed the title
|
Thanks for updating the version, which means Gatsby will get the libwebp fixes too. lovell/sharp#3798 |
pieh
pushed a commit
that referenced
this pull request
Oct 6, 2023
* chore(deps): upgrade sharp to latest v0.32.5 Ensures some PNG-related test snapshots use deterministic raw pixel data rather than non-deterministic compressed byte streams. * chore(deps): upgrade sharp to latest v0.32.6 --------- Co-authored-by: Michal Piechowiak <[email protected]> (cherry picked from commit ca15ef3)
gatsbybot
added a commit
that referenced
this pull request
Oct 9, 2023
* chore(deps): upgrade sharp to latest v0.32.5 Ensures some PNG-related test snapshots use deterministic raw pixel data rather than non-deterministic compressed byte streams. * chore(deps): upgrade sharp to latest v0.32.6 --------- Co-authored-by: Michal Piechowiak <[email protected]> (cherry picked from commit ca15ef3) Co-authored-by: Lovell Fuller <[email protected]>
This was referenced Oct 30, 2023
This was referenced Dec 22, 2023
This was referenced Dec 29, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades all packages to depend on a minimum version of sharp of the latest v0.32.5, which is strongly recommended for those processing untrusted input - please see lovell/sharp#3739
The prebuilt binaries provided with latest version of sharp include zlib-ng v2.1.3, which makes PNG processing much faster, but when encoding can produce a slightly different compressed byte stream when run on different CPUs (the decompressed byte stream is identical). This will affect tests that rely on an exact match of compressed PNG data, hence this PR updating a few tests to compare decoded raw pixel data rather than encoded byte streams.
Tests
This PR updates tests but I have yet to get a completely clean run via CircleCI as a couple of e2e tests appear to be reaching configured timeouts. I can't work out if the failures are related to this change or not.
https://app.circleci.com/pipelines/github/lovell/gatsby/8/workflows/b6962479-f4f8-4ff2-bfea-e8da72cc39ec