-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Add clarification for Pro Tip on Part 4 of tutorial #36918
Conversation
It may have been just me, but when I was following this part of the tutorial (https://www.gatsbyjs.com/docs/tutorial/part-4/#:~:text=export%20default%20BlogPage-,Pro%20Tip%3A,-The%20Gatsby%20Head). I copied and pasted the code and replaced what I already had in the Head of my blog page, since I was following it sequentially. I faced various errors since the GraphQL query didn't have the data for the metadata; only to realize this was already handled by the Seo components some steps ago. So I wanted to make a note to make it clear that this wasn't necessary since we had the Seo component already. Also, the video tutorial doesn't mention or show this tip so it took me longer to realize my mistake.
Hi, thanks for the PR! Currently I'm more inclined to close the PR as we have announcements with "Pro Tip" throughout the tutorial. They are always separate callouts independent from the flow so I'm interested to know why for this specific "Pro Tip" you thought it would be about the tutorial? |
Hi @LekoArts! No problem! This is my first PR so thanks for giving some feedback on the fit for it. However I understand your take, the Tips do actually "live on their own"; it could have been just a "zoned out" moment for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the input! I adjusted your changes to point out part 6 of the tutorial, hope that makes it clearer
Thank you for the time and feedback! The summary of the note made it much clearer! |
Description
It may have been just me, but when I was following this part of the tutorial. I copied and pasted the code and replaced what I already had in the Head of my blog page, since I was following it sequentially. I faced various errors since the GraphQL query didn't have the data for the metadata; only to realize this was already handled by the Seo components some steps ago. So I wanted to make a note to make it clear that this wasn't necessary since we had the Seo component already.
Also, the video tutorial (pretty good!) doesn't mention or show this tip so it took me longer to realize my mistake.
Documentation
https://www.gatsbyjs.com/docs/tutorial/part-4/
Related Issues
No related issues.