fix(gatsby): move require out of hot function #36253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This require showed up in a performance profile as taking ~600ms during a large query as `resolveField` is called a lot. We can require it out of the function to avoid this.
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: performance
imjoshin
reviewed
Jul 27, 2022
imjoshin
approved these changes
Jul 28, 2022
|
A lot more of the |
Nevermind, just more than I remembered. 😂 |
21 tasks
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This require showed up in a performance profile as taking ~600ms (~5-10%) during a large query as
resolveFieldis called a lot. We can memoize the require to avoid this.