-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-core-utils): fix urls without extension #34930
Merged
gatsbybot
merged 2 commits into
master
from
wardpeet/sc-46853/issues-related-to-gatsby-core-utils-fetch
Feb 25, 2022
Merged
fix(gatsby-core-utils): fix urls without extension #34930
gatsbybot
merged 2 commits into
master
from
wardpeet/sc-46853/issues-related-to-gatsby-core-utils-fetch
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 25, 2022
wardpeet
changed the title
fix(gatsby-core-utils): fix urls without extension"
fix(gatsby-core-utils): fix urls without extension
Feb 25, 2022
wardpeet
added
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
type: bug
An issue or pull request relating to a bug in Gatsby
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 25, 2022
pieh
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
pieh
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Feb 25, 2022
gatsbybot
deleted the
wardpeet/sc-46853/issues-related-to-gatsby-core-utils-fetch
branch
February 25, 2022 12:17
LekoArts
pushed a commit
that referenced
this pull request
Feb 25, 2022
* add test * fix(gatsby-core-utils): fix urls without extension (cherry picked from commit 728af63)
LekoArts
pushed a commit
that referenced
this pull request
Feb 25, 2022
Co-authored-by: Ward Peeters <[email protected]>
Published in
|
2 tasks
wow i reported a bug yesterday, today it is fixed! thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
type: bug
An issue or pull request relating to a bug in Gatsby
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where remote url doesn't provide extension and doesn't apply it when found from source file