Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview 2.0 UI changes #34440

Merged
merged 12 commits into from
Jan 11, 2022
Merged

preview 2.0 UI changes #34440

merged 12 commits into from
Jan 11, 2022

Conversation

pvorozhe
Copy link
Contributor

Implementing ui changes from Preview UI 2.90 Figma

Description:

  1. Rearrange icons
  2. Move functionality for the info button (from the Gatsby icon button)
  3. Include "notification icon" and red dot for existing contifications
  4. Minor code rearrangements

Images

Screen Shot 2022-01-06 at 3 22 29 PM
Screen Shot 2022-01-06 at 3 22 19 PM
Screen Shot 2022-01-06 at 3 21 32 PM
Screen Shot 2022-01-06 at 3 21 25 PM
Screen Shot 2022-01-06 at 3 20 08 PM
Screen Shot 2022-01-06 at 3 44 05 PM
Screen Shot 2022-01-06 at 3 24 11 PM

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 10, 2022
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :D will the html diffing logic when builds complete be part of this PR? If not, we should wait on this change https://github.com/gatsbyjs/gatsby/pull/34440/files#diff-5c04c0efa41cd68622ac03da3d8d7b6144d680bec06b6bc36f04b4cae1b3bb8cL49

packages/gatsby-plugin-gatsby-cloud/package.json Outdated Show resolved Hide resolved
@pvorozhe
Copy link
Contributor Author

Nice :D will the html diffing logic when builds complete be part of this PR? If not, we should wait on this change https://github.com/gatsbyjs/gatsby/pull/34440/files#diff-5c04c0efa41cd68622ac03da3d8d7b6144d680bec06b6bc36f04b4cae1b3bb8cL49

good call. I want to address it as a separate pr, im not 100% sure its a plugin-only change.

Comment on lines +38 to +40
: () => {
setShowTooltip(!showTooltip)
}
Copy link
Contributor

@DanielSLew DanielSLew Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit but not a huge fan of inlining functions like this with a ternary op, I think it makes it harder to read even if they're straightforward

@@ -1,6 +1,7 @@
import React, { useState } from "react"
import { IndicatorButtonTooltip } from "../tooltips"
import { spinnerIcon } from "../icons"
import { spinnerIcon, exitIcon } from "../icons"
import { props } from "bluebird"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for? we don't use it anywhere

iconSvg={infoIcon}
onMouseEnter={buttonProps?.active && trackHover}
iconSvg={buttonProps?.showInfo ? infoIconActive : infoIcon}
onClick={buttonProps?.active && trackHover}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense? We're tracking the hover when the button is being clicked now?

@smthomas smthomas merged commit db188dc into master Jan 11, 2022
@smthomas smthomas deleted the pvorozhe/preview2-changes branch January 11, 2022 21:17
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 12, 2022
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jan 12, 2022
* master:
  fix(gatsby-core-utils): Re-Export updateSiteMetadata (gatsbyjs#34462)
  fix(deps): update starters and examples gatsby packages to ^4.5.1 (gatsbyjs#34463)
  fix(gatsby-dev-cli): Do not ignore engines (gatsbyjs#34461)
  fix(gatsby): Revert gatsbyjs#33786 (gatsbyjs#34458)
  fix(deps): update starters and examples - gatsby (gatsbyjs#34449)
  chore(changelogs): update changelogs (gatsbyjs#34451)
  Update tutorial part 1 to reflect changes to add site flow (gatsbyjs#34427)
  preview 2.0 UI changes (gatsbyjs#34440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants