preview 2.0 UI changes #34440
preview 2.0 UI changes #34440
Conversation
gatsbot
bot
added
the
status: triage needed
There was a problem hiding this comment.
Nice :D will the html diffing logic when builds complete be part of this PR? If not, we should wait on this change https://github.com/gatsbyjs/gatsby/pull/34440/files#diff-5c04c0efa41cd68622ac03da3d8d7b6144d680bec06b6bc36f04b4cae1b3bb8cL49
good call. I want to address it as a separate pr, im not 100% sure its a plugin-only change. |
| : () => { | ||
| setShowTooltip(!showTooltip) | ||
| } |
There was a problem hiding this comment.
Just a nit but not a huge fan of inlining functions like this with a ternary op, I think it makes it harder to read even if they're straightforward
| @@ -1,6 +1,7 @@ | |||
| import React, { useState } from "react" | |||
| import { IndicatorButtonTooltip } from "../tooltips" | |||
| import { spinnerIcon } from "../icons" | |||
| import { spinnerIcon, exitIcon } from "../icons" | |||
| import { props } from "bluebird" | |||
There was a problem hiding this comment.
What's this for? we don't use it anywhere
packages/gatsby-plugin-gatsby-cloud/src/components/buttons/InfoIndicatorButton.js
Show resolved
Hide resolved
| iconSvg={infoIcon} | ||
| onMouseEnter={buttonProps?.active && trackHover} | ||
| iconSvg={buttonProps?.showInfo ? infoIconActive : infoIcon} | ||
| onClick={buttonProps?.active && trackHover} |
There was a problem hiding this comment.
Does this make sense? We're tracking the hover when the button is being clicked now?
packages/gatsby-plugin-gatsby-cloud/src/components/buttons/LinkIndicatorButton.js
Outdated
Show resolved
Hide resolved
LekoArts
added
topic: plugins
* master: fix(gatsby-core-utils): Re-Export updateSiteMetadata (gatsbyjs#34462) fix(deps): update starters and examples gatsby packages to ^4.5.1 (gatsbyjs#34463) fix(gatsby-dev-cli): Do not ignore engines (gatsbyjs#34461) fix(gatsby): Revert gatsbyjs#33786 (gatsbyjs#34458) fix(deps): update starters and examples - gatsby (gatsbyjs#34449) chore(changelogs): update changelogs (gatsbyjs#34451) Update tutorial part 1 to reflect changes to add site flow (gatsbyjs#34427) preview 2.0 UI changes (gatsbyjs#34440)
Implementing ui changes from Preview UI 2.90 Figma
Description:
Images
Documentation
Related Issues