-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby): Add types for getServerData
#34406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 5, 2022
…into fix/get-server-data-types
pieh
added
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jan 6, 2022
pieh
reviewed
Jan 6, 2022
pieh
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
pieh
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Jan 6, 2022
LekoArts
changed the title
Add types for getServerData
chore(gatsby): Add types for Jan 6, 2022
getServerData
This was referenced Oct 9, 2024
This was referenced Oct 10, 2024
This was referenced Oct 12, 2024
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getServerData
does not currently have any types around it. This code change should allow developers to have type safety within this method for each page.Note: this does change the type of the old
IServerData
's headers from a Record to a Map. There were inconsistencies in it's typing, so this syncs them up. Please mention any concerns there may be with this conversion.Using the example from Gatsby's SSR doc, and given the following type:
We can get type safety in an anonymous function using the given shorthand:
Or if we use a named function, we can use the Props and Return types:
[sc-38899]