Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): use lmdb.removeSync so getNode can't return deleted nodes (#33554) #33633

Merged
merged 1 commit into from
Oct 22, 2021
Merged

fix(gatsby): use lmdb.removeSync so getNode can't return deleted nodes (#33554) #33633

merged 1 commit into from
Oct 22, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Oct 22, 2021

Backport #33554 to release/3.14 release branch.

(cherry picked from commit 98a843c)

# Conflicts:
#	packages/gatsby/src/datastore/lmdb/lmdb-datastore.ts

@KyleAMathews @vladar
fix(gatsby): use lmdb.removeSync so getNode can't return deleted nodes (
cd16cca 
#33554)

Co-authored-by: Ward Peeters <[email protected]>
(cherry picked from commit 98a843c)

# Conflicts:
#	packages/gatsby/src/datastore/lmdb/lmdb-datastore.ts
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 22, 2021
@vladar vladar added type: cherry and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 22, 2021
@vladar
Copy link
Contributor Author

vladar commented Oct 22, 2021

Oh well, gatsby-dev-cli now fails with Node12 in v3 test. Gonna ignore test failures as this backport only touches the experimental codepath in v3.

@vladar vladar merged commit d4cf891 into release/3.14 Oct 22, 2021
@vladar vladar deleted the backport-3.14-33554 branch October 22, 2021 18:54
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 6, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 6, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Jun 6, 2022
Open
This was referenced Jun 6, 2022
Open
Open
This was referenced Jun 7, 2022
Open
Open
This was referenced Jun 7, 2022
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jun 7, 2022
Open
This was referenced Jun 7, 2022
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 7, 2022
Open
@0xSebin 0xSebin mentioned this pull request Jun 7, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 7, 2022
Open
This was referenced Jun 7, 2022
Open
Open
Open
This was referenced Jun 7, 2022
Open
Open
@0xSebin 0xSebin mentioned this pull request Jun 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 7, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 22, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Aug 17, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 18, 2023
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
type: cherry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladar @KyleAMathews