fix(gatsby-plugin-image): GatsbyImage not displaying image in IE11 #33416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
raresportan
changed the title
|
Great work, @raresportan. I saw that the tests were failing even before your work. I initially thought that this PR is not ready for review because the checks were failing. |
Sadly the tests fail even on master branch. It would be great to make them pass yes. |
This was referenced Oct 5, 2021
…ix/gatsby-plugin-image/ie11
|
@LekoArts, when you have a moment, can you please help with reviewing this PR? @raresportan has done a great job with it. Thank you! 🍻 |
LekoArts
added
topic: media
|
Thank you for waiting, tested it thoroughly, and works like a charm! |
wardpeet
approved these changes
Oct 29, 2021
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
vladar
pushed a commit
that referenced
this pull request
Nov 2, 2021
…33416) (#33806) (cherry picked from commit d708d91) Co-authored-by: Rares Portan <[email protected]>
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
This was referenced Jun 6, 2022
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picture element should not have position relative since there is another container,
gatsby-image-wrapperthat contains the image.The fix is applied only for picture elements with class
object-fit-polyfill, which is added byobjectFitPolyfillonly for browsers that don't support theobject-fitCSS property (e.g. IE11). The evergreen browsers are not affected by this fix.Sadly I had to use !important because the position relative is added by
objectFitPolyfillas inline style.Related Issues
Fixes #30053
@wardpeet I see #30053 is assigned to you for a while, hopefully this helps.