-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): add this typings to actions #32210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid unnecessary warnings from @typescript-eslint/unbound-method see https://github.com/typescript-eslint/typescript-eslint/blob/v4.28.0/packages/eslint-plugin/docs/rules/unbound-method.md
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jul 2, 2021
ping @wardpeet @LekoArts @KyleAMathews @pieh 🥺 |
wardpeet
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great! Sorry for the wait!
wardpeet
changed the title
fix(gatsby): hint that helpers are bounded
fix(gatsby): add this typings to actions
Aug 27, 2021
wardpeet
added
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Aug 27, 2021
wardpeet
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Aug 27, 2021
This was referenced Aug 31, 2021
This was referenced Oct 19, 2024
This was referenced Oct 20, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commonly, we destruct the
action
field as well as other helper functions from the API argument like this:These functions are bounded and it's 100% safe to invoke these functions since they do not access
this
.However, the current type file doesn't explicitly state that and hence would trigger a warning from some linting tools such as
@typescript-eslint/unbound-method
This PR declares it explicitly and therefore avoid unnecessary warnings
See https://github.com/typescript-eslint/typescript-eslint/blob/v4.28.0/packages/eslint-plugin/docs/rules/unbound-method.md