fix(gatsby): infer shape of warning object #31489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
previously requested changes
May 21, 2021
vladar
added
topic: webpack/babel
Co-authored-by: Vladimir Razuvaev <[email protected]>
Co-authored-by: Vladimir Razuvaev <[email protected]>
LekoArts
approved these changes
Jun 14, 2021
vladar
pushed a commit
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: gatsbybot <[email protected]> (cherry picked from commit 96dc88a)
vladar
pushed a commit
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: gatsbybot <[email protected]> (cherry picked from commit 96dc88a) Co-authored-by: Kyle Mathews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different parts of webpack seem to be emitting warnings in different shapes. They were all strings it seems in v4 and then became objects in webpack 5 but only mostly? Not really sure. But
this PR tries to just infer the different shapes warnings can come in and handle them.
fixes #31474