Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create multiple layouts from same components with different context #3039

Merged
merged 2 commits into from
Nov 27, 2017
Merged

fix: create multiple layouts from same components with different context #3039

merged 2 commits into from
Nov 27, 2017

Conversation

abumalick
Copy link
Contributor

fix: create multiple layouts from same components with different context

As explained in #3025 : when we try to create multiple layouts with different context from one component, we notice that we get only the last layout created.

The bug appears in pages-writer.js:89 , we have to use the layout id as identifier instead of his path

Thanks to @yachaka for pointing out the source of the bug

fixes #3025

The bug appears in pages-writer.js:89 , we need to use the layout id as identifier instead of his path

fixes #3025
@gatsbybot
Copy link
Collaborator

gatsbybot commented Nov 26, 2017

Deploy preview ready!

Built with commit 0f900fe

https://deploy-preview-3039--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit e3734d3

https://deploy-preview-3039--using-drupal.netlify.com

@yachaka
Copy link

yachaka commented Nov 27, 2017

this is great! thanks for taking care of the PR @abumalick

@KyleAMathews
Copy link
Contributor

Ah cool! Yeah, this makes a lot of sense. Thanks for the investigative work + PR!

@jlengstorf
Copy link
Contributor

Hiya @abumalick! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating 2 layouts from same component with different context
5 participants