fix(gatsby-plugin-preact): fix fast-refresh #29831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: preact*
and removed
status: triage needed
wardpeet
force-pushed
the
fix/preact-fast-refresh
branch
from
8b26569
to
7f53f23
Compare
vladar
approved these changes
Mar 1, 2021
vladar
pushed a commit
that referenced
this pull request
Mar 1, 2021
(cherry picked from commit 81a3776)
vladar
pushed a commit
that referenced
this pull request
Mar 1, 2021
(cherry picked from commit 81a3776) Co-authored-by: Ward Peeters <[email protected]>
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Apr 15, 2024
This was referenced May 16, 2024
This was referenced Oct 13, 2024
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix fast-refresh for gatsby-plugin-preact.
The runtime module isn't being loaded when using preact so gatsbyEvents is not set. This also disables our error modals 😬 that's another bug to fix but at least this fixes updates