-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): fix root resolving of resources #29577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 18, 2021
wardpeet
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 19, 2021
wardpeet
force-pushed
the
fix/url-resolving
branch
2 times, most recently
from
February 22, 2021 13:56
ef1cab5
to
3d0cc91
Compare
wardpeet
commented
Feb 23, 2021
wardpeet
force-pushed
the
fix/url-resolving
branch
from
February 24, 2021 00:41
41b7560
to
e8c05c8
Compare
vladar
reviewed
Feb 24, 2021
pieh
reviewed
Feb 24, 2021
e2e-tests/production-runtime/cypress/integration/resource-loading-resilience.js
Show resolved
Hide resolved
wardpeet
commented
Feb 24, 2021
Co-authored-by: Ward Peeters <[email protected]>
pieh
force-pushed
the
fix/url-resolving
branch
from
February 24, 2021 15:03
24e6e95
to
50d6613
Compare
pieh
approved these changes
Feb 24, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes url resolving by ignoring / queries but allow relative ones to be resolved by webpack.
Currently this doesn't load in the browser
This does when it's inside the /static folder or copied to the public folder.
With this PR both work.
I've also added a test to see that we don't regress in the future.