-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-image): Change fullWidth to use breakpoints #29002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 12, 2021
ascorbic
added
topic: media
Related to gatsby-plugin-image, or general image/media processing topics
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jan 12, 2021
ascorbic
changed the title
feat(gatsby-plugin-image): Change fluid to use breakpoints
feat(gatsby-plugin-image): Change fullWidth to use breakpoints
Jan 13, 2021
laurieontech
suggested changes
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. Definitely think it'll generate more appropriate sizes in the majority of cases.
Co-authored-by: LB <[email protected]>
laurieontech
previously approved these changes
Jan 13, 2021
ascorbic
added
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
and removed
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
labels
Jan 13, 2021
This was referenced Jan 19, 2021
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API for fullWidth images. Instead of using maxWidth and pixel density to determine output image sizes, this uses fixed breakpoint sizes. Includes default breakpoints of
[750, 1080, 1366, 1920]
. Any breakpoint that is larger than the source image is filtered-out, and the source width is added instead.