Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-dev-cli): install deps if there are no gatsby deps but --forceInstall was used #27055

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 25, 2020

This is just QoL:

Right now our test script for e2e and integration tests all use gatsby-dev-cli to install deps. Next PR in the series will remove gatsby-cli dep from https://github.com/gatsbyjs/gatsby/blob/master/integration-tests/gatsby-cli/package.json which would make our test setup just not install anything currently (even jest).


This is part of PR series:

  1. feat(gatsby-dev-cli): install deps if there are no gatsby deps but --forceInstall was used (THIS PR)
  2. test(integration/gatsby-cli): use sandboxed directory to "globally" install gatsby-cli
  3. chore(gatsby-recipes): bundle dependencies
  4. chore(gatsby-cli): bundle dependencies

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 25, 2020
@pieh pieh added topic: dev tooling and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 25, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 25, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 20m

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pieh pieh merged commit b6cde3b into master Sep 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/bundle-cli-and-recipes/gatsby-dev-cli branch September 28, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants