fix(starters): Improve null checking & update to best practices #26918
Conversation
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 19m |
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
| previous, | ||
| next, | ||
| }, | ||
|
|
There was a problem hiding this comment.
This check shouldn't be needed, because if the array is empty, the forEach never happens anyway. However, what might be needed is a null check on allMarkdownRemark. Does that exist if there's no markdown? Shame there's no optional chaining in gatsby-node!
There was a problem hiding this comment.
I prefer to make it more explicit as I myself can't always remember that e.g. forEach would behave this way
|
|
||
| // Also explicitly define the Markdown frontmatter | ||
| // This way the "MarkdownRemark" queries will return `null` even when no | ||
| // blog posts are stored inside "content/blog" instead of returning an error |
There was a problem hiding this comment.
Haha, well that answers my question. Does it need a null check or does it have an empty nodes array?
There was a problem hiding this comment.
It's an empty array then :)
There was a problem hiding this comment.
The markdownRemark query returns null
| <Layout location={location} title={siteTitle}> | ||
| <SEO title="All posts" /> | ||
| <Bio /> | ||
| <p>No blog posts found. Add markdown posts to "content/blog" (or the directory you specified for the "gatsby-source-filesystem" plugin in gatsby-config.js).</p> |
There was a problem hiding this comment.
Big fan of this approach. Nice work.
|
<3 |
| <a href={`https://twitter.com/${social?.twitter || ``}`}> | ||
| You should follow them on Twitter |
There was a problem hiding this comment.
i think, if there is no twitter name is set, then this a tag shot not printed?
…byjs#26918) Co-authored-by: Matt Kane <[email protected]>
Description
In order to reduce friction when people modify the
defaultandblogstarters I improved those two a bit. Both with newer best practices but also safe-guarding againstnullby using optional chaining. Furthermore a bit of schema customization forblogwas added.edges { node }tonodesNOT FOUNDto something better for screen readersNotes
In theory we could also define the default values for e.g.
siteMetadataitems in the schema customization but I think JS code is more discover-able and easier to understand.