Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gatsby-plugin-mdx not running plugins on findImports(...) #26191

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

lucasterra
Copy link
Contributor

Description

This makes findImports(...) also run the run(...) phase from unified/remark. This is needed to allow plugins to inject ESM imports via AST modifications. I have also added a test to cover this use case.

Documentation

#25437 broke a use case that I had a custom plugin for. Basically, I need to inject imports via a plugin to enable code demos.

@lucasterra lucasterra requested a review from a team as a code owner August 2, 2020 12:40
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 2, 2020
@pvdz pvdz added topic: MDX type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 3, 2020
@pvdz
Copy link
Contributor

pvdz commented Aug 3, 2020

Thank you for the test case. Super helpful 💜

Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and including a test! 🙏🙏🙏

@johno johno merged commit ae5f581 into gatsbyjs:master Aug 3, 2020
@gatsbot
Copy link

gatsbot bot commented Aug 3, 2020

Holy buckets, @lucasterra — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants