perf(gatsby-source-contentful): experimental flag to skip id normalization #25473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an experimental flag,
EXPERIMENTAL_CONTENTFUL_SKIP_NORMALIZE_IDS
, to skip the normalization step when sourcing from Contentful.This step would take the
sys.id
and force it to a string and not start with a number. This step is quite expensive at scale, easily taking 5 minutes or more, because it has to traverse every property on every object of the content retrieved by Contentful.While this step may have been necessary a long time ago, everybody agrees that today it's not required.
We may concretely remove the step in the future, but since that's a breaking change (people can query the
contentful_id
field in graphql, or access thecontentful_id
property directly inside a node) that's going to take a little longer to be published. This flag serves as a workaround until that time.