fix(gatsby-remark-embed-snippet): readme - add example sources #24874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
muescha
changed the title
danabrit
added
status: needs docs review
AishaBlake
added
type: documentation
AishaBlake
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Hey, @muescha! I support this change but I'd like to wrap the no-highlight block around a copy of the existing code block, like we do in the style guide. I've made that change and will go ahead and merge once tests pass.
|
@AishaBlake yes. Thats much better 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes:
no-highlightto be rendered nice on https://www.gatsbyjs.org/packages/gatsby-remark-embed-snippet/#highlighting-linesQuestions
shoud we add a
sourceandresultline before each?on github https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-remark-embed-snippet/README.md they would rendered twice (because highlight lines commands are not processed)
while on Gatsby docs page https://www.gatsbyjs.org/packages/gatsby-remark-embed-snippet/#highlighting-lines they rendered as source/result
Related Issues
fix(gatsby-remark-embed-snippet): readme - change code language