fix(gatsby-plugin-sharp): presentation sizes #23905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
reviewed
May 8, 2020
pieh
reviewed
May 8, 2020
pvdz
added
status: needs core review
Co-authored-by: Michal Piechowiak <[email protected]>
|
Deploy request for suspicious-hermann-8c5e26 pending review. Review with commit 9b6cc2d https://app.netlify.com/sites/suspicious-hermann-8c5e26/deploys |
pieh
reviewed
May 12, 2020
pieh
added
the
topic: media
2 tasks
pieh
requested changes
May 16, 2020
|
Finally green 😂 |
pieh
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to our latest changes to gatsby-plugin-sharp, it seems that
presentationWidth&presentationHeightaren't calculated correctly when bothmaxWidth&maxHeightare given. From now on, we read the width & height out of the resulted image instead of calculating it ourselves.Related Issues
#17006 (comment)