Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert prefer-default and log-line-function to TS #23677

Merged
merged 2 commits into from
May 5, 2020

Conversation

gabrieluizramos
Copy link
Contributor

Description

In order to continue the conversion, this PR converts prefer-default and log-line-function (with the related imports) to TS.

Related Issues

Related to #21995

@gabrieluizramos gabrieluizramos requested review from a team as code owners May 1, 2020 15:38
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 1, 2020
@gabrieluizramos gabrieluizramos force-pushed the ts/prefer-default-and-log-line-function branch 2 times, most recently from 9692ea6 to 8bc5d47 Compare May 1, 2020 17:52
@gabrieluizramos gabrieluizramos force-pushed the ts/prefer-default-and-log-line-function branch from 8bc5d47 to 8d30d96 Compare May 1, 2020 17:54
@gabrieluizramos gabrieluizramos force-pushed the ts/prefer-default-and-log-line-function branch from 8d30d96 to 0317b53 Compare May 1, 2020 18:18
@TylerBarnes TylerBarnes added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 1, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants