Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(blog): 100days challenge 13 #22568

Merged
merged 5 commits into from
Mar 25, 2020
Merged

docs(blog): 100days challenge 13 #22568

merged 5 commits into from
Mar 25, 2020

Conversation

hashimwarren
Copy link
Contributor

@hashimwarren hashimwarren commented Mar 25, 2020 •
edited
Loading

New 100daysofgatsby challenge. This week is all about comments. Ready for review

@hashimwarren hashimwarren marked this pull request as ready for review March 25, 2020 17:35
@hashimwarren hashimwarren requested a review from a team as a code owner March 25, 2020 17:35
@hashimwarren hashimwarren changed the title (blog) Draft of challenge 13 (blog) 100days challenge 13 Mar 25, 2020
@mgienow
Copy link
Contributor

mgienow commented Mar 25, 2020

I'll review this now, no need for Learning to jump in :)

mgienow
mgienow approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@mgienow mgienow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

mgienow
mgienow previously approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@mgienow mgienow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I really mean it!

@mgienow mgienow added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 25, 2020
wardpeet
wardpeet approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! thanks @hashimwarren

@gatsbybot gatsbybot merged commit 3f2d75c into master Mar 25, 2020
@wardpeet wardpeet changed the title (blog) 100days challenge 13 docs(blog): 100days challenge 13 Mar 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the 100days-challenge-13 branch March 25, 2020 18:56
@muescha muescha mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@mgienow mgienow mgienow left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hashimwarren @mgienow @wardpeet @gatsbybot