Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-simple-blog-with-asciidoctor #21875

Merged
merged 8 commits into from
Mar 4, 2020
Merged

chore(starters): add gatsby-simple-blog-with-asciidoctor #21875

merged 8 commits into from
Mar 4, 2020

Conversation

hituzi-no-sippo
Copy link
Contributor

@hituzi-no-sippo hituzi-no-sippo commented Mar 1, 2020

Description

If there are explanation that is difficult to understand in the README, please let me know. I will fix.

@hituzi-no-sippo hituzi-no-sippo requested a review from a team as a code owner March 1, 2020 07:22
@gillkyle
Copy link
Contributor

gillkyle commented Mar 2, 2020

Looks like there are some merge conflicts but your PR is from your fork of Gatsby. Could you resolve those by accepting both changes?

One other note, could you add some set up instructions to your repositories REEADME for setting up a site based on your starter with gatsby new https://github.com/hitsuji-no-shippo/gatsby-simple-blog-with-asciidoctor and running it with gatsby develop? It looks neat 🙂

@gillkyle gillkyle added the status: awaiting author response Additional information has been requested from the author label Mar 2, 2020
@gillkyle gillkyle self-assigned this Mar 2, 2020
@hituzi-no-sippo
Copy link
Contributor Author

Hi.

Looks like there are some merge conflicts but your PR is from your fork of Gatsby. Could you resolve those by accepting both changes?

I resolved the conflicts.

One other note, could you add some set up instructions to your repositories REEADME for setting up a site based on your starter with gatsby new https://github.com/hitsuji-no-shippo/gatsby-simple-blog-with-asciidoctor and running it with gatsby develop? It looks neat 🙂

I'm Sorry. Added introduction using gatsby commands in this commit

@gillkyle gillkyle removed the status: awaiting author response Additional information has been requested from the author label Mar 4, 2020
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hitsuji-no-shippo! 🎉

@gillkyle gillkyle merged commit 28cdc4e into gatsbyjs:master Mar 4, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 4, 2020

Holy buckets, @hitsuji-no-shippo — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@hituzi-no-sippo hituzi-no-sippo deleted the patch-1 branch March 4, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants