Move buildTime into new node type #21827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiksenet
suggested changes
Feb 28, 2020
packages/gatsby/src/internal-plugins/internal-data-bridge/gatsby-node.js
Show resolved
Hide resolved
vladar
reviewed
Feb 28, 2020
packages/gatsby/src/internal-plugins/internal-data-bridge/gatsby-node.js
Outdated
Show resolved
Hide resolved
vladar
reviewed
Feb 28, 2020
packages/gatsby/src/internal-plugins/internal-data-bridge/gatsby-node.js
Show resolved
Hide resolved
freiksenet
approved these changes
Mar 2, 2020
freiksenet
added
the
bot: merge on green
|
Published in |
This was referenced Mar 17, 2020
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a new node type
SiteBuildTime, with one node that includes abuildTimefield. It then replaces the buildTime field onSitewith a resolver that returns the value from theSiteBuildTimenode. This prevents changes to buildTime affecting the Site node contentDigest, which would mark any page that uses siteMetadata as dirty.Based on discussion #21795 (comment)
Related Issue
Replaces #21795