Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Cloudflare Workers documentation #21658

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

exvuma
Copy link
Contributor

@exvuma exvuma commented Feb 21, 2020

closes #21652

@exvuma exvuma requested review from a team as code owners February 21, 2020 20:16
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! This is a great addition. I made some recommendations for the headings. I'd make them either headings or numbers, not both. This will need a tech review (along with the recipe) so I'm adding it to our list of review docs and we should get to it shortly.

docs/blog/100days/free-hosting/index.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
www/src/data/tags-docs.js Outdated Show resolved Hide resolved
@bball07
Copy link
Contributor

bball07 commented Feb 25, 2020

Hello @victoriabernard92,

Great work on this! I'm working through the steps and running into some trouble with this error:

Error: Your user configuration is invalid, please run wrangler config and enter a new set of credentials.

I think I followed the steps as they were outlined here, is there anything I may be missing?

@exvuma
Copy link
Contributor Author

exvuma commented Feb 26, 2020

Error: Your user configuration is invalid, please run wrangler config and enter a new set of credentials.

@bball07 Sorry for your trouble. You will need to run wrangler config and then will be prompted for your Cloudflare API Token. Steps on how to generate your token are in this article. Were you able to generate your token?

@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Mar 3, 2020
@exvuma
Copy link
Contributor Author

exvuma commented Mar 4, 2020

@LekoArts anything I can do to help on this?

Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @victoriabernard92! Thanks for the work on this, it's looking really awesome 🎉 I walked through the steps and found them straightforward. I did have some issues towards the end with what seemed like was needing a paid plan for Cloudflare KV. You get a free subdomain but seems like you don't get free hosting? Is there a way we could explain the difference between the free subdomain and need for a premium plan on KV to host a site like this?

I left a few suggestions for your consideration as well.

docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Outdated Show resolved Hide resolved
docs/docs/deploying-to-cloudflare-workers.md Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
@gillkyle gillkyle added the status: awaiting author response Additional information has been requested from the author label Mar 9, 2020
@exvuma exvuma requested a review from gillkyle March 10, 2020 19:31
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those edits @victoriabernard92 🙂 I pulled it locally to look at it on my machine and found a broken link. Rather than adding another suggestion I just pushed to your fork. I think it's good to go now, thanks for adding the note about the plans as well (I also added it to the recipe and reordered the recipe to match the list on the recipe overview page).

Thanks for the contribution!

@gillkyle gillkyle changed the title Add Cloudflare Workers documentation docs: add Cloudflare Workers documentation Mar 11, 2020
@gillkyle gillkyle removed the status: awaiting author response Additional information has been requested from the author label Mar 11, 2020
@gillkyle gillkyle merged commit dce6e11 into gatsbyjs:master Mar 11, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 11, 2020

Holy buckets, @victoriabernard92 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cloudflare Workers Sites to the Deployment and Hosting Docs
6 participants