Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting Multiple Site Showcase Contributions #21501

Merged
merged 3 commits into from
Feb 16, 2020

Conversation

axthomas29
Copy link
Contributor

Description

Updated sites.yml file to add site showcase contributions for review

Documentation

Related Issues

@axthomas29 axthomas29 requested a review from a team as a code owner February 15, 2020 22:16
@axthomas29 axthomas29 requested a review from a team as a code owner February 15, 2020 22:27
@gatsbybot
Copy link
Collaborator

docs/sites.yml: SyntaxError: Document is not valid YAML (bad indentation?) (9734:5)
   9732 |       - Blog
   9733 |       - Web Development
 > 9734 |     built_by: Alexandra Thomas
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 9735 |     built_by_url: https://alexandracthomas.com
        | ^
   9736 |     featured: false
   9737 | - title: Storto Productions
   9738 |   main_url: https://www.storto-productions.com/

Copy link
Contributor

@bball07 bball07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!! This looks amazing!! I am going to merge this :)

Copy link
Contributor

@bball07 bball07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You

@bball07 bball07 merged commit 9357549 into gatsbyjs:master Feb 16, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 16, 2020

Holy buckets, @axthomas29 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@marcysutton
Copy link
Contributor

It looks like this PR introduced a file that shouldn’t be part of the showcase, can someone explain why it was included? Thank you 🙏

@axthomas29
Copy link
Contributor Author

@marcysutton After I sent the final pull I did notice there was a separate file that was outside of the "sites.yml" file that I edited in my request. I wasn't quite sure if that was added as in part of Code Contributions guideline I followed or something else. I left it alone in fear of messing something up. All I know is...it's a mystery to me! 🔍

I'm sure this isn't a significant file and can be removed and hopefully won't cause any issues. 👍

Sorry about that! 😬 Thank you!!!!

@axthomas29
Copy link
Contributor Author

@marcysutton Let me know if you need me to remove it, etc. 😊

@marcysutton
Copy link
Contributor

@axthomas29 thanks for the update! This has been resolved in master, so you can disregard. It should have been caught on our end, but no worries for the future and thanks again for your contribution!

@axthomas29
Copy link
Contributor Author

@marcysutton Woohoo! Glad it has been resolved!

You are very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants