-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submitting Multiple Site Showcase Contributions #21501
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!! This looks amazing!! I am going to merge this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You
Holy buckets, @axthomas29 — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
It looks like this PR introduced a file that shouldn’t be part of the showcase, can someone explain why it was included? Thank you 🙏 |
@marcysutton After I sent the final pull I did notice there was a separate file that was outside of the "sites.yml" file that I edited in my request. I wasn't quite sure if that was added as in part of Code Contributions guideline I followed or something else. I left it alone in fear of messing something up. All I know is...it's a mystery to me! 🔍 I'm sure this isn't a significant file and can be removed and hopefully won't cause any issues. 👍 Sorry about that! 😬 Thank you!!!! |
@marcysutton Let me know if you need me to remove it, etc. 😊 |
@axthomas29 thanks for the update! This has been resolved in master, so you can disregard. It should have been caught on our end, but no worries for the future and thanks again for your contribution! |
@marcysutton Woohoo! Glad it has been resolved! You are very welcome! |
Description
Updated sites.yml file to add site showcase contributions for review
Documentation
Related Issues