Don't use app.js. Move its functionality to webpack.config.js/gatsby-client-utils.js #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app.js had three weirdly merged features. 1. It held the require.context magic function stuff from Webpack to autoload page modules from the `pages` directory. 2. You could export a function to programatically rewrite paths. 3. You could export a function which would get run on every route change (useful for things like tracking path changes in Google Analytics). This PR moves the require.context to a an auto-written file. This sets the stage for #208. To rewrite paths, now export the same function from gatsby.config.js. And for `onRouteChange`, export this from `gatsby-client-utils.js` which is for client-only user functions used by Gatsby core.
KyleAMathews
force-pushed
the
remove-app.js
branch
from
13e9b09
to
1055368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app.js had three weirdly merged features.
autoload page modules from the
pagesdirectory.(useful for things like tracking path changes in Google Analytics).
This PR moves the require.context to a an auto-written file. This sets
the stage for #208. To rewrite paths, now export the same function from
gatsby.config.js. And for
onRouteChange, export this fromgatsby-client-utils.jswhich is for client-only user functions used by Gatsby core.Fixes #17