fix(gatsby-source-contentful): Bypass schema validation for null nodes for fixed/fluid media assets

[ryanhefner]

Description

Fix Contentful schema validation for null nodes for fixed or fluid media assets.

Documentation

N/A

Related Issues

#20696

[pvdz]

Thank you for this fix! The null case was indeed not caught.

I hope that's not going to lead to a problem down the road but in here it is definitely necessary.

[gatsbot]

Holy buckets, @ryanhefner — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[pvdz]

I'm looking at this and I'm convinced it could just be

resolve: (image, options, context) =>
  Promise.resolve(resolveFixed(image, options)).then(node => {

into

resolve: async (image, options, context) =>
  const node = resolveFixed(image, options)

And it would be the same thing. The resolveFixed func is never returning a promise so there's no need (anymore?) for the Promise.resolve. The async keyword will ensure a promise is returned to preserve that api.

Not sure if it makes any difference but would be clearer. Oh well, this was unrelated to this PR, I was just confused looking at it :)