Removed unnecessary component state, used props instead

[alexisshriov]

removed unnecessary component state

Description

there is no need to have a state in this component, we can use props directly

Documentation

this is part of the documentation of LanguageSwitcher, is a code example.

Related Issues

[pieh]

I was looking through this component, and now I wonder if we even need to have state here at all? It just seems like it's just shortcut for this.props.i18n.language (?)

[alexisshriov]

@pieh you are probably right, the only place where it's used is in renderLanguageChoice, and is just making a comparison, it could use props for the same purpose, do you want me to change it?

[pieh]

@pieh you are probably right, the only place where it's used is in renderLanguageChoice, and is just making a comparison, it could use props for the same purpose, do you want me to change it?

If it doesn't have any functional difference, we should change it to drop using state.

When to Use Derived State section in react docs is good place to read a little bit about usage of derived state, and I don't think this case is good one for it

[pieh]

It even explitely calls "Unconditionally copying props to state" as anti-pattern ;) few section later

[alexisshriov]

I was using it as a replacement for componentWillReceiveProps which was already there, but since we don't even need to have a component state then the whole thing is unnecessary, if you want me I can remove the component state and just use props

[pieh]

if you want me I can remove the component state and just use props

If you could do that, that would be awesome!

[alexisshriov]

@pieh okay I think it's done

[pieh]

Ok, there is just that line after edited code block:

This is a pretty simple component. We're setting the language state based on the i18n prop so that we can check which language is currently active and show that in our menu.

That needs a bit of adjust as we don't have state anymore - maybe something like (additionally trying to avoid language like "easy"):

This is a pretty small component. We are using i18n prop so that we can check which language is currently active and show that in our menu

(feel free to reword in different way)

[alexisshriov]

@pieh you are right!, okay I finished the text change, let me know if you want me to change anyhting else :)

[pieh]

Awesome, thanks!

[pieh]

I think we are good - it should automatically merge pull request now once all the checks finish

[alexisshriov]

@pieh thank you!

[gatsbot]

Holy buckets, @alexisshriov — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!