Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(gatsby): Use a Map instead of Object for job id lookups #20605

Merged
merged 1 commit into from
Jan 15, 2020
Merged

perf(gatsby): Use a Map instead of Object for job id lookups #20605

merged 1 commit into from
Jan 15, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Jan 14, 2020

A Map is designed for this work where an object will deoptimize after a handful of different keys.

@pvdz
perf(gatsby): Use a Map instead of Object for job id lookups
643e868 
A Map is designed for this work where an object will deoptimize after a handful of different keys.
@pvdz pvdz requested a review from a team as a code owner January 14, 2020 21:38
vladar
vladar approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 15, 2020
@gatsbybot gatsbybot merged commit 54fb530 into master Jan 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the query-runner-map branch January 15, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdz @vladar @gatsbybot