-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[www] Cards for Blog index #2017
Conversation
Refine light purple and sidebar colors. Explicitly set excerpt for (two) blog articles along the way.
Deploy preview ready! Built with commit 8c20947 |
Looking great! The wording on the two excerpts looks good to me. BTW, there's an error when building www right now. |
Grrrr … lemme have a look. |
Fixed … 🙄 😅 If you're okay with the other two excerpts being truncated this is good to go from my side (not saying that all is done of course ;-)). Split view for contributor pages next … or sidebar?! |
It might be nice to have the whole card be clickable |
Also something that could be fun is to add back the "Blog" header but add some old fashioned curly whatevers around it to look like an old-fashioned nameplate/masthead |
Wow, you actually read my mind twice, both were on my (secret ;)) list! You hit the nail on the head regarding the masthead – when I wrote about "keeping the Will fix the link in a few. To keep the link to the author page working, we can either handle clicks via JS, add another |
Currently done by overlaying the newly added "Read more" link over the entire card and pushing the link to the author's page up via `z-index`. Has the drawback of the text not being user-selectable anymore. Changed BlogPostPreviewItem root HTML element from `<div>` to `<article>` along the way.
Thanks!! |
… and >="Tablet", below that breakpoint it's basically still the same layout for now. Minus the "Blog" headline, which I haven't thought about at all up to writing this TBH… (wouldn't be wrong to keep it around I guess,
and properly hide it with screenreaders in mind).Explicitly sets the excerpt for (two) blog articles along the way – just so much nicer already without that ellipsis (maybe we should go for extracting the first paragraph somehow). Anyways, those two excerpts probably still need some editing … maybe you could take a look @KyleAMathews and @DSchau? 🙏
Also refines the "light purple" and sidebar colors – all are now a little warmer, moved towards the homepage masthead backgrounds left triangle color, and brings the sidebars webkit scrollbar thumb color in line with the brand.