Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): fix links with null in template-contributor-page.js #19852

Merged
merged 1 commit into from
Nov 28, 2019
Merged

fix(www): fix links with null in template-contributor-page.js #19852

merged 1 commit into from
Nov 28, 2019

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Nov 28, 2019 •
edited
Loading

Description

in docs/blog/author.yaml some contributors without twitter handle - for example:

this creates a empty link to https://twitter.com/null

Related Issues

#19267

@muescha muescha requested a review from a team as a code owner November 28, 2019 06:58
@pieh pieh changed the title contributors: fix links with null in template-contributor-page.js fix(www): fix links with null in template-contributor-page.js Nov 28, 2019
pieh
pieh approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit b075706 into gatsbyjs:master Nov 28, 2019
@muescha muescha deleted the muescha/fix/twitter-null-contributor branch November 29, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muescha @pieh