<BrowserRouter> ignores the history prop. #1913

[3axap4eHko]

No description provided.

[gatsbybot]

Deploy preview ready!

Built with commit eb7f298

https://deploy-preview-1936--gatsbygram.netlify.com

[KyleAMathews]

The <Router> component is the low-level component higher-level ones like <BrowserRouter> use and is what you're supposed to use with custom history implementations.

[KyleAMathews]

I made the same change to the production entry file/router implementation.

Thanks!

[3axap4eHko]

@KyleAMathews I think production change is not necessary be cause there are no runtime history object changes

[KyleAMathews]

@3axap4eHko I think it's necessary as there's an API to make customizations to the history object which I guess wasn't working without this?

[KyleAMathews]

Deploy preview failed.

Built with commit eb7f298

https://app.netlify.com/sites/using-glamor/deploys/59a469457960b17dd8d3faac

[jlengstorf]

Hiya @3axap4eHko! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜