Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Add self-signed cert to node trust store (https) #18703
fix(gatsby): Add self-signed cert to node trust store (https) #18703
Changes from 28 commits
12accb6
5540d13
cc82fcc
6e99fae
393429e
a126ffb
c0a4ac8
77530fe
1edfef2
73cf13f
dc486a5
730d980
e56a7c5
ebce67d
5b0533c
0483702
73d61cc
ff0f4c8
76f1197
9a60c68
91742a4
04a6074
07dc617
cf381df
e360131
5c7caa2
2398966
ea47440
edc486a
4296400
fffaa0d
f2ac0a1
daed896
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "a record in your hosts file, " be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About removing that phrase: this process is not contingent on there being a record in the hosts file, so saying "if you have a record in your hosts file, it will automatically be configured" wouldn't be accurate.
If we remove "a record in your hosts file, ", then "it" becomes kind of vague in this context... what is "it"? If the goal is to make it a bit less technical, maybe it could read?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wardpeet any thoughts?