Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-cli): convert hooks into class component #15903

Merged
merged 1 commit into from
Jul 19, 2019
Merged

fix(gatsby-cli): convert hooks into class component #15903

merged 1 commit into from
Jul 19, 2019

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 19, 2019 •
edited
Loading

Description

  • Converted Develop component from hooks to class component.
  • Add error logging to ink when our react component goes south.
    image
  • I also added telemetry to make sure we track it.

Related Issues

Fixes #14911

@wardpeet wardpeet requested a review from a team as a code owner July 19, 2019 12:34
@wardpeet wardpeet changed the title fix(gatsby-cli): convert hooks into component fix(gatsby-cli): convert hooks into class component Jul 19, 2019
wardpeet
wardpeet commented Jul 19, 2019
View reviewed changes
packages/gatsby-cli/src/reporter/reporters/ink/reporter.js
}

componentDidCatch(error, info) {
trackBuildError(`INK`, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamo how do I track this error properly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this looks correct

sidharthachatterjee
sidharthachatterjee approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sidharthachatterjee sidharthachatterjee merged commit 0ab03f5 into gatsbyjs:master Jul 19, 2019
@wardpeet wardpeet deleted the fix/ink-hooks-npm branch July 19, 2019 13:34
@sidharthachatterjee
Copy link
Contributor

sidharthachatterjee commented Jul 19, 2019 •
edited
Loading

Published in [email protected] and [email protected]

@wardpeet wardpeet mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-cli 2.6.12 error: RangeError: Maximum call stack size exceeded
2 participants
@wardpeet @sidharthachatterjee