-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create gatsby-image-tutorial #15027
Create gatsby-image-tutorial #15027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for putting this together! I made a bunch of suggestions, some are based on the Gatsby Style Guide and some are to enhance the reading experience. Eventually it would be great to have a better story for querying multiple images (say, from a folder) but I think using YAML is a fine solution for now.
I'd love to get some additional feedback from @amberleyromo and @shannonbux. I know Shannon is on vacation until next week so it might take us a little bit, but hopefully not too long.
Thanks again for your work on this @lstar19!
Thanks Marcy! I'll wait for all the feedback to come in and then incorporate it together. Thanks for taking the time. |
Here's some feedback from @shannonbux!
I think the most actionable thing here is to update the tutorial to match the format outlined in the tutorial template, along with my comments. I love Shannon's suggestion of having a starter project for people to play with–that could be an improvement done later on, as a separate PR. Thanks again for working on this tutorial, we really appreciate it and you! |
Added all your recommended changes Marcy and tried to do some of the "step" stuff up top. What I'm realizing is there are so many paths to take depending on use case that breaking it down into steps is a bit more challenging past initial set up. Should we break this until multiple tutorials? Or are we ok with this branching? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, it's in really good shape! I left a few suggestions that should help with the forking question, @lstar19.
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Co-Authored-By: Marcy Sutton <[email protected]>
Made some edits, looking at it with a narrow view to gatsby-image I'm wondering if I should remove the entire section titled |
@lstar19 I think it's useful to include the aliases info. |
In that case, I think it might be ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the tutorial to the sidebar and renamed the Wordpress image tutorial as part of this work! It should be ready to merge now. Thanks for your work on it @lstar19!
* Create gatsby-image-tutorial * gatsby-image rework * Update docs/tutorial/gatsby-image-tutorial/gatsby-image-tutorial.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/tutorial/gatsby-image-tutorial/gatsby-image-tutorial.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/tutorial/gatsby-image-tutorial/gatsby-image-tutorial.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/tutorial/gatsby-image-tutorial/gatsby-image-tutorial.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/tutorial/gatsby-image-tutorial/gatsby-image-tutorial.md Co-Authored-By: Marcy Sutton <[email protected]> * Update docs/tutorial/gatsby-image-tutorial/gatsby-image-tutorial.md Co-Authored-By: Marcy Sutton <[email protected]> * addressing comments and feedback * fix image-tutorial URL, add to sidebar * rename wordpress image tutorial, add redirects
Thanks Marcy! |
Description
This is the first draft of a potential tutorial for using gatsby-image in various ways.
Related Issues
Addresses #9374