Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add preoptimizing your images documentation #11809

Merged
merged 7 commits into from
Feb 22, 2019

Conversation

oorestisime
Copy link
Contributor

Contributes: #11798

I am not sure this was the best place possible to add this part of documentation.
Let me know if you think it is more appropriate to move this elsewhere (in plugin-sharp ?)

@oorestisime oorestisime requested a review from a team February 15, 2019 22:34
@oorestisime
Copy link
Contributor Author

@DSchau i wasn't sure how to specify that you did the script. i was thinking to add it as a comment in the code example.

@oorestisime oorestisime requested a review from a team as a code owner February 15, 2019 22:44
@oorestisime
Copy link
Contributor Author

I need to update this based on the discussion on twitter yesterday. Didn't yet have the time to do it.

@DSchau DSchau changed the title Document why pre-optimizing images is important docs: add preoptimizing your images documentation Feb 22, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked a few things, but merging this in.

Thanks for this--it's very much appreciated!

@DSchau DSchau merged commit 20edbc5 into gatsbyjs:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants