Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for more date/time formats #11520

Closed
wants to merge 2 commits into from

Conversation

miktirr
Copy link

@miktirr miktirr commented Feb 3, 2019

Description

Support for YYYY-MM-DD HH:mm:ss Z could be useful since this is the format Jekyll uses in the frontmatter. Supporting the same format would make it easier to move from Jekyll to Gatsby.

It’s not perfectly clear to me if using a space instead of the uppercase T is valid in ISO 8601 format (strictly speaking probably not), but at least Moment.js regards these as valid date strings and handles them in the same way as those with the T.

Support for `YYYY-MM-DD HH:mm:ss Z` since this is the format [Jekyll uses](https://jekyllrb.com/docs/front-matter/#predefined-variables-for-posts) in the frontmatter.
@miktirr miktirr requested a review from a team as a code owner February 3, 2019 14:52
@DSchau DSchau added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Feb 27, 2019
@wardpeet
Copy link
Contributor

I'll let @freiksenet & @pieh comment on this one. I have no idea how this works 😋

@wardpeet
Copy link
Contributor

We are working on big changes to GraphQL in #11480. We plan to merge it next week. I wonder if you could either wait until next week and make a new PR against master or just make the PR for the schema refactor branch. Otherwise there will be merge conflicts that might result in this code getting lost.

I quoted this from #12511

@wardpeet wardpeet added status: awaiting author response Additional information has been requested from the author and removed status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Mar 12, 2019
@miktirr
Copy link
Author

miktirr commented Mar 13, 2019

Thanks for the info! This can wait, and I can open a new PR against the master after the schema refactor branch has been merged.

It might also be that the schema refactor itself makes these changes unnecessary, and the #12533 by @himynameistimli would seem to address the same concerns anyway.

So probably just close this PR for now.

@wardpeet
Copy link
Contributor

Thanks so much for the PR and we're very sorry about this!

We're going to close this out. We want you to know that we certainly want to keep you as a contributor to Gatsby, so we'd encourage you to check out our open issues.

Thanks again, and we look forward to seeing more PRs from you in the future! 💪 💜

@wardpeet wardpeet closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants