Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create the building-a-blog stub article #10748

Closed
wants to merge 11 commits into from

Conversation

vojoup
Copy link

@vojoup vojoup commented Jan 1, 2019

This PR closes #[10447] by creating the 'Building a blog' article.

This is the first draft of this article.
@vojoup vojoup requested a review from a team January 1, 2019 13:44
@vojoup
Copy link
Author

vojoup commented Jan 1, 2019

I didn't find the "Use cases with Gatsby" section.
Should this section be created?
If yes, where?

@vojoup vojoup changed the title Create the building-a-blog sutb article [docs] Create the building-a-blog stub article Jan 1, 2019
@shannonbux
Copy link
Contributor

Hi @vojoup! Thanks for volunteering to write this! The section "Use cases with Gatsby" does need to be created, thanks for noticing that!

docs/docs/building-a-blog.md Outdated Show resolved Hide resolved
docs/docs/building-a-blog.md Outdated Show resolved Hide resolved
Change the wording according to @shannonbux comment.
Link now leads to the 'Using starters' section of the main tutorial.
@vojoup
Copy link
Author

vojoup commented Jan 1, 2019

So where should this article be placed? 🙂

@shannonbux
Copy link
Contributor

Thanks @vojoup! This link shows where the section and article should go 0aade74?diff=unified. Right above "Adding website functionality." You only need to add this one article in the section--ignore the other stub articles!

@vojoup vojoup requested a review from a team as a code owner January 1, 2019 21:03
@vojoup
Copy link
Author

vojoup commented Jan 1, 2019

Is this the right place? 🙂

@shannonbux
Copy link
Contributor

shannonbux commented Jan 1, 2019

Hi @vojoup, no, it should look like this

// add this section
- title: Use cases with Gatsby (including apps)
  link: /docs/building-apps-with-gatsby/
  items:
  - title: Building a blog
    link: /docs/building-a-blog/
// end of new section
- title: Adding website functionality
  link: /docs/adding-website-functionality/

@vojoup
Copy link
Author

vojoup commented Jan 1, 2019

Sorry got a bid confused there plus it's getting late here... 😀

@vojoup
Copy link
Author

vojoup commented Jan 3, 2019

Hello @shannonbux, I see that something is wrong with the build and that it's somehow related to these files: docs/docs/building-a-blog.md, docs/docs/client-data-fetching.md, and www/src/data/sidebars/doc-links.yaml, but I can't see any info about what is actually wrong with them.
Is there something I can do?

@shannonbux
Copy link
Contributor

alright @vojoup! I fixed a couple small issues. This is good from a docs perspective. Just waiting for a technical review now.

@vojoup
Copy link
Author

vojoup commented Jan 4, 2019

@shannonbux thank you very much!🙂

@shannonbux
Copy link
Contributor

shannonbux commented Jan 4, 2019 via email

@DSchau DSchau changed the title [docs] Create the building-a-blog stub article docs: create the building-a-blog stub article Jan 4, 2019
@shannonbux
Copy link
Contributor

@pieh does this need a code owner review?

@vojoup
Copy link
Author

vojoup commented Jan 16, 2019

Hello @shannonbux , @pieh, is there anything needed from me?

@vojoup
Copy link
Author

vojoup commented Jan 22, 2019

@pieh, @shannonbux Can I help any further ?

@calcsam
Copy link
Contributor

calcsam commented Jan 25, 2019

My personal vote is for closing this, now that we've gotten rid of the use-cases section, it doesn't really fit in the flow anymore. I'm going to close this for now, although if we ever have a dedicated section with eg ecommerce somewhere else in the docs, we could re-open.

Thanks for the work and sorry @vojoup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants