docs: add ibm case study blog post #10474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| The new Carbon Design System website launched October 3, 2018, and is referenced by designers and developers as an open source project as well as internally at IBM. With a seamless design feel, most users didn’t “see” any changes, but they sure felt them with the lightning fast page load times. Alison pointed out their new Lighthouse performance score went from 7 to 96 (that’s a 89 point jump!) with PWA, Accessibility, Best Practices, and SEO scores in the high 90s - 100. | ||
|
|
||
| ## Lighthouse Performance Scores with Gatsby |
There was a problem hiding this comment.
Seems a bit weird to have a section that's just an image and a pullquote? @lindaleebumblebee
There was a problem hiding this comment.
This relates to the section above....I want to show the lighthouse scores and thought it needed a title for the image but it really is part of the section above. Do you have a recommendation on how to make this part of the section above it but still have a description/title for the image?
There was a problem hiding this comment.
I'd suggest removing the header text and adding a caption to the image.
There was a problem hiding this comment.
Great- that works for me (@amberleyromo 's suggestion about the caption to the image instead of header text).
|
ah nice filter idea @DSchau. Didn't know abt that |
wconnorwalsh
added a commit
to wconnorwalsh/gatsby
that referenced
this pull request
Dec 17, 2018
* master: docs: add ibm case study blog post (gatsbyjs#10474) Update sites.yml (gatsbyjs#10512) Update starters.yml (gatsbyjs#10505) chore(release): Publish fix(graphql-skip-limit): fix hasNextPage (gatsbyjs#10504) chore: use cjs instead of esm for consistency (gatsbyjs#10494) feat(gatsby-remark-copy-linked-files): add support for video elements with `src` attribute (gatsbyjs#10395) typofix (gatsbyjs#10488) Add kobit.in to showcase (gatsbyjs#10496) fix(docs): window.reload => window.location.reload (gatsbyjs#10459) # Conflicts: # packages/gatsby/CHANGELOG.md # packages/gatsby/package.json
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
cc @lindaleebumblebee One thing I _keep_ forgetting is that we don't _have_ to merge this PR Monday. We have a `released: true` filter that excludes post in the future, so if this looks good we can merge whenever. <!-- Q. Which branch should I use for my pull request? A. Your best bet is to go for `master`. If you are unsure, ask in the PR, and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lindaleebumblebee
One thing I keep forgetting is that we don't have to merge this PR Monday. We have a
released: truefilter that excludes post in the future, so if this looks good we can merge whenever.