Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to node-tracking.js file #10429

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Fix link to node-tracking.js file #10429

merged 1 commit into from
Dec 12, 2018

Conversation

igghera
Copy link
Contributor

@igghera igghera commented Dec 12, 2018

I was reading the docs and I found that the link to node-tracking.js was taking me to Github's 404 page, so I looked into the repo and found it had been moved from /schema to /db.
I checked the referenced lines (9 and 32) and they do match the function names cited in the docs.

I was reading the docs and I found that the link to `node-tracking.js` was taking me to Github's 404 page, so I looked into the repo and found it had been moved from `/schema` to `/db`.
I checked the referenced lines (9 and 32) and they do match the function names cited in the docs.
@igghera igghera requested a review from a team December 12, 2018 09:20
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit 37f26c0 into master Dec 12, 2018
@pieh pieh deleted the igghera-patch-node-tracking branch December 12, 2018 13:16
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
I was reading the docs and I found that the link to `node-tracking.js` was taking me to Github's 404 page, so I looked into the repo and found it had been moved from `/schema` to `/db`.
I checked the referenced lines (9 and 32) and they do match the function names cited in the docs.

<!--
  Q. Which branch should I use for my pull request?
  A. Your best bet is to go for `master`. If you are unsure, ask in the PR, and a Gatsby mantainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants