Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): fix newsletter form style on blog post pages #10180

Merged
merged 1 commit into from
Nov 28, 2018
Merged

fix(www): fix newsletter form style on blog post pages #10180

merged 1 commit into from
Nov 28, 2018

Conversation

greglobinski
Copy link
Contributor

Revert unintentional braking changes to style of the Newsletter form on Blog post pages applied during implementation of the same form presented on redesigned Hompage Newsletter section.

  • broken style

screenshot from 2018-11-28 13-54-21

  • fixed style (with this PR), the form looks the same as before refactoring of www/src/components/email-capture-form.js

screenshot from 2018-11-28 13-53-55

@greglobinski greglobinski requested a review from a team as a code owner November 28, 2018 13:06
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @greglobinski! 🙏

@pieh pieh merged commit 90ed649 into gatsbyjs:master Nov 28, 2018
@greglobinski greglobinski deleted the gl/blogpostpage/form-fix branch November 28, 2018 20:45
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Revert unintentional braking changes to style of the Newsletter form on Blog post pages applied during implementation of the same form presented on redesigned Hompage Newsletter section. 

- broken style 

![screenshot from 2018-11-28 13-54-21](https://user-images.githubusercontent.com/32480082/49153447-0b58d000-f316-11e8-9e75-213f74830768.png)

- fixed style (with this PR), the form looks the same as before refactoring of `www/src/components/email-capture-form.js`

![screenshot from 2018-11-28 13-53-55](https://user-images.githubusercontent.com/32480082/49153446-0ac03980-f316-11e8-929b-40e800ced254.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants