Use Gatsby V2 project structure #10059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the guide "Migrating from v1 to v2" (https://www.gatsbyjs.org/docs/migrating-from-v1-to-v2/#2-move-layoutsindexjs-to-srccomponentslayoutjs-optional-but-recommended). The project structure has the layout file now on "src/components/layout.js" instead of "layouts/index.js"
LekoArts
reviewed
Nov 21, 2018
| @@ -135,7 +135,7 @@ CSS along your PrismJS theme and the styles for `.gatsby-highlight-code-line`: | |||
|
|
|||
| If you want to add line numbering alongside your code, you need to | |||
| import the corresponding CSS file from PrismJS, right after importing your | |||
| colorscheme in `layout/index.js`: | |||
| colorscheme in `src/components/layout.js`: | |||
|
|
|||
| ```javascript | |||
| // layouts/index.js | |||
There was a problem hiding this comment.
Don’t forget this comment 😛
There was a problem hiding this comment.
Sorry, this is my first contribution on this project and I see that you have collaborated before. Is there anything wrong with my PR? Thank beforehand for any feedback.
There was a problem hiding this comment.
Ah, no, your proposed change is fine I guess. Just wanted to mention that you also should change the comment inside the codeblock
There was a problem hiding this comment.
@albertod Do you have time to make that change?
Change also the path on the comment for the new location of the layout.js file
LekoArts
approved these changes
Dec 6, 2018
|
Holy buckets, @albertod — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
m-allanson
added a commit
to kaoDev/gatsby
that referenced
this pull request
Dec 7, 2018
* master: (870 commits) fix(graphql-skip-limit): declare `graphql` peer dependency (gatsbyjs#10305) fix(gatsby-plugin-offline): gracefully degrade if appshell isn't precached (gatsbyjs#10329) Service workers note (gatsbyjs#10276) fix(docs): link fixes, podcast addition (gatsbyjs#10332) feat(docs): Create clearer pathways in docs (gatsbyjs#9898) feat(www): Rename community section to creators (gatsbyjs#10312) docs(graphql-reference): clarify filtering using comma/and operator (gatsbyjs#10321) chore(release): Publish feat(gatsby-plugin-sass): Support Dart SASS (gatsbyjs#10159) fix(gatsby-source-drupal): use basic auth credentials to fetch remote files as well. (gatsbyjs#10302) fix(gatsby-source-filesystem): allow empty password for basic auth in createRemoteFileNode (gatsbyjs#10280) docs(gatsby-remark-prismjs): Use Gatsby V2 project structure (gatsbyjs#10059) chore: update link for react-gatsby-firebase-authentication (gatsbyjs#10314) fix(www): Awesome Gatsby sidebar link (gatsbyjs#10313) Add thijs koerselman to creators list (gatsbyjs#10303) chore(release): Publish fix(gatsby-plugin-emotion): allow for React.Fragment shorthand syntax (gatsbyjs#10291) feat(www): Update starter cards (gatsbyjs#10258) Update index.md (gatsbyjs#10307) Update index.md (gatsbyjs#10306) ...
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…s#10059) From the guide "Migrating from v1 to v2" (https://www.gatsbyjs.org/docs/migrating-from-v1-to-v2/#2-move-layoutsindexjs-to-srccomponentslayoutjs-optional-but-recommended). The project structure has the layout file now on "src/components/layout.js" instead of "layouts/index.js" <!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the guide "Migrating from v1 to v2" (https://www.gatsbyjs.org/docs/migrating-from-v1-to-v2/#2-move-layoutsindexjs-to-srccomponentslayoutjs-optional-but-recommended). The project structure has the layout file now on "src/components/layout.js" instead of "layouts/index.js"