graphql dependency is mismatched with graphql-compose

[adambaratz]

Preliminary Checks

• This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues
• This issue is not a question, feature request, RFC, or anything other than a bug report directly related to Gatsby. Please post those things in GitHub Discussions: https://github.com/gatsbyjs/gatsby/discussions

Description

There is a known issue with graphql-compose where it technically depends on graphql v16, but isn't explicit about it. Gatsby, after #34787, depends on this package but depends on an earlier version of graphql. As a result, the TypeScript compiler fails unless you enable the skipLibCheck option.

Reproduction Link

N/A

Steps to Reproduce

...

Expected Result

No errors with tsc.

Actual Result

$ tsc
node_modules/graphql-compose/lib/type/buffer.d.ts:3:25 - error TS2315: Type 'GraphQLScalarType' is not generic.

3 declare const _default: GraphQLScalarType<Buffer, string>;
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/graphql-compose/lib/type/date.d.ts:2:25 - error TS2315: Type 'GraphQLScalarType' is not generic.

2 declare const _default: GraphQLScalarType<Date, string>;
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 2 errors.

Environment

.

Config Flags

No response

[adambaratz]

Apologies if I short-circuited the template in an unhelpful way, but I think the fix is as simple as updating the graphql dependency (assuming that doesn't break anything). If it would be helpful to create a very simple project to be able to reproduce, I can do that.

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[github-actions]

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

[chris48s]

Commenting because this issue has not been fixed

[ctmm]

Also experiencing issues with this topic

[LekoArts]

While on paper it's "just" updating graphql the breaking changes list is quite long:

https://github.com/graphql/graphql-js/releases/tag/v16.0.0

We'd appreciate any help with putting up a PR updating it and assessing which breaking changes affect us and if this would also mean a breaking change for Gatsby users.

[ctmm]

In the meantime, we've downgraded our version of graphql-composer – the package triggering the conflict – as a fix.
On package.json:

  "overrides": {
    "gatsby": {
      "graphql-compose": "9.0.4"
    },
    "gatsby-plugin-manifest": {
      "graphql-compose": "9.0.4"
    },
    "gatsby-plugin-utils": {
      "graphql-compose": "9.0.4"
    }
  },

At the same time, I'm unsure if the issue will be fixed by upgrading Gatsby's graphql version.
graphql-compose/graphql-compose#383
graphql-compose/graphql-compose#374

Should we fix it by downgrading Gatsby's desired version of graphql-compose?

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[adambaratz]

Still an issue.

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[LekoArts]

Downgrading graphql-compose is not an option by the way.