Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Broken anchor link in Adding Images, Fonts, and Files #11297

Closed
tatchi opened this issue Jan 25, 2019 · 3 comments
Closed

[docs] Broken anchor link in Adding Images, Fonts, and Files #11297

tatchi opened this issue Jan 25, 2019 · 3 comments
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@tatchi
Copy link
Contributor

tatchi commented Jan 25, 2019

Description

There's a broken link in the "Adding Images, Fonts, and Files" section of the documentation.

At the bottom of the page (within the "When to Use the static Folder"), the "stylesheets" link does not seem to work.

see: https://www.gatsbyjs.org/docs/adding-images-fonts-files/#when-to-use-the-static-folder

It tries to redirect to a position elsewhere in the page, but I couldn't find a spot in the page where we talk about importing stylesheet. Therefore, I don't really know what to replace this link with.

Maybe redirect to the top of the page (and use the same link than the "images, and fonts" text just next to the "stylesheets" one)?

What do you think?

@tatchi tatchi added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 25, 2019
@sidharthachatterjee
Copy link
Contributor

Thank you for opening this @tatchi

The link is broken and while we can change it to /#adding-images-fonts-files, that section doesn't mention anything about stylesheets and could be confusing.

I'd probably lean towards removing the stylesheets word from that sentence entirely but I think @shannonbux should have a better idea here.

@shannonbux
Copy link
Contributor

For now, just removing the hyperlink but leaving the word there might work best. I don't have the technical expertise to know what we could link to, but at least this would get rid of the broken link.

Thanks!

PS I did some digging to figure out what this was supposed to link to, and no luck. This is the issue that led to the creation of this doc in the first place, though the link was broken in the first draft of this doc too: #9222

@tatchi
Copy link
Contributor Author

tatchi commented Feb 2, 2019

Thanks for your suggestions 👍

Here's the PR: #11499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests

3 participants