removed apikey references/usage from shopify plugin (#32024) (#32033)

(cherry picked from commit 47cf675) Co-authored-by: Daniel Lew <[email protected]>
gatsbyjs · Jun 22, 2021 · 549cca9 · 549cca9
1 parent cb914ae
commit 549cca9
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 18 deletions.
diff --git a/packages/gatsby-source-shopify/README.md b/packages/gatsby-source-shopify/README.md
@@ -76,7 +76,6 @@ module.exports = {
     {
       resolve: "gatsby-source-shopify",
       options: {
-        apiKey: process.env.SHOPIFY_ADMIN_API_KEY,
         password: process.env.SHOPIFY_ADMIN_PASSWORD,
         storeUrl: process.env.SHOPIFY_STORE_URL,
       },
@@ -131,10 +130,6 @@ Now follow the second link to explore your Shopify data!
 
 ## Plugin options
 
-`apiKey: string`
-
-The admin API key for the Shopify store + app you're using
-
 `password: string`
 
 The admin password for the Shopify store + app you're using
@@ -250,7 +245,6 @@ module.exports = {
     {
       resolve: "gatsby-source-shopify",
       options: {
-        apiKey: process.env.SHOPIFY_ADMIN_API_KEY,
         password: process.env.SHOPIFY_ADMIN_PASSWORD,
         storeUrl: process.env.SHOPIFY_STORE_URL,
         downloadImages: true,

diff --git a/packages/gatsby-source-shopify/__tests__/make-source-from-operation.ts b/packages/gatsby-source-shopify/__tests__/make-source-from-operation.ts
@@ -133,7 +133,6 @@ describe(`The collections operation`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
       downloadImages: true,
@@ -248,7 +247,6 @@ describe(`When polling an operation`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
       downloadImages: true,
@@ -339,7 +337,6 @@ describe(`When downloading images`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
       downloadImages: true,
@@ -446,7 +443,6 @@ describe(`A production build`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
     }
@@ -513,7 +509,6 @@ describe(`A production build`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
     }
@@ -604,7 +599,6 @@ describe(`When an operation gets canceled`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
     }
@@ -677,7 +671,6 @@ describe(`When an operation fails with bad credentials`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
     }
@@ -827,7 +820,6 @@ describe(`The incremental products processor`, () => {
 
     const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
       downloadImages: true,

diff --git a/packages/gatsby-source-shopify/__tests__/node-builder.ts b/packages/gatsby-source-shopify/__tests__/node-builder.ts
@@ -56,7 +56,6 @@ describe(`When a variant has an image set`, () => {
 
   describe(`and options are set, not to download images`, () => {
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
     }
@@ -70,7 +69,6 @@ describe(`When a variant has an image set`, () => {
 
   describe(`and options are set to download images`, () => {
     const options = {
-      apiKey: ``,
       password: ``,
       storeUrl: `my-shop.shopify.com`,
       downloadImages: true,

diff --git a/packages/gatsby-source-shopify/src/gatsby-node.ts b/packages/gatsby-source-shopify/src/gatsby-node.ts
@@ -25,7 +25,6 @@ export function pluginOptionsSchema({
   // Vague type error that we're not able to figure out related to isJoi missing
   // Probably related to Joi being outdated
   return Joi.object({
-    apiKey: Joi.string().required(),
     password: Joi.string().required(),
     storeUrl: Joi.string()
       .pattern(/^[a-z0-9-]+\.myshopify\.com$/)

diff --git a/packages/gatsby-source-shopify/types/interface.d.ts b/packages/gatsby-source-shopify/types/interface.d.ts
@@ -1,5 +1,4 @@
 interface ShopifyPluginOptions {
-  apiKey: string;
   password: string;
   storeUrl: string;
   downloadImages?: boolean;